Messages in this thread | | | Date | Mon, 21 Feb 2022 15:15:51 +0100 | Subject | Re: [PATCH v4 07/15] crypto: dh - implement ffdheXYZ(dh) templates | From | Hannes Reinecke <> |
| |
On 2/21/22 13:10, Nicolai Stange wrote: > Current work on NVME in-band authentication support ([1]) needs to invoke > DH with the FFDHE safe-prime group parameters specified in RFC 7919. > > Introduce a new CRYPTO_DH_RFC7919_GROUPS Kconfig option. If enabled, make > dh_generic register a couple of ffdheXYZ(dh) templates, one for each group: > ffdhe2048(dh), ffdhe3072(dh), ffdhe4096(dh), ffdhe6144(dh) and > ffdhe8192(dh). Their respective ->set_secret() expects a (serialized) > struct dh, just like the underlying "dh" implementation does, but with the > P and G values unset so that the safe-prime constants for the given group > can be filled in by the wrapping template. > > Internally, a struct dh_safe_prime instance is being defined for each of > the ffdheXYZ(dh) templates as appropriate. In order to prepare for future > key generation, fill in the maximum security strength values as specified > by SP800-56Arev3 on the go, even though they're not needed at this point > yet. > > Implement the respective ffdheXYZ(dh) crypto_template's ->create() by > simply forwarding any calls to the __dh_safe_prime_create() helper > introduced with the previous commit, passing the associated dh_safe_prime > in addition to the received ->create() arguments. > > [1] https://lore.kernel.org/r/20211202152358.60116-1-hare@suse.de > > Signed-off-by: Nicolai Stange <nstange@suse.de> > --- > crypto/Kconfig | 6 + > crypto/dh.c | 298 ++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 303 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
| |