lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 098/227] selftests: netfilter: fix exit value for nft_concat_range
    Date
    From: Hangbin Liu <liuhangbin@gmail.com>

    commit 2e71ec1a725a794a16e3862791ed43fe5ba6a06b upstream.

    When the nft_concat_range test failed, it exit 1 in the code
    specifically.

    But when part of, or all of the test passed, it will failed the
    [ ${passed} -eq 0 ] check and thus exit with 1, which is the same
    exit value with failure result. Fix it by exit 0 when passed is not 0.

    Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
    Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
    Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/testing/selftests/netfilter/nft_concat_range.sh | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/testing/selftests/netfilter/nft_concat_range.sh
    +++ b/tools/testing/selftests/netfilter/nft_concat_range.sh
    @@ -1601,4 +1601,4 @@ for name in ${TESTS}; do
    done
    done

    -[ ${passed} -eq 0 ] && exit ${KSELFTEST_SKIP}
    +[ ${passed} -eq 0 ] && exit ${KSELFTEST_SKIP} || exit 0

    \
     
     \ /
      Last update: 2022-02-21 19:22    [W:2.131 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site