This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri Apr 19 18:31:36 2024 >From mailfetcher Sun Feb 20 13:23:16 2022 Envelope-to: lkml@grols.ch Delivery-date: Sun, 20 Feb 2022 13:23:15 +0100 Received: from stout.grols.ch [195.201.141.146] by 72459556e3a9 with IMAP (fetchmail-6.3.26) for (single-drop); Sun, 20 Feb 2022 13:23:16 +0100 (CET) Received: from out1.vger.email ([2620:137:e000::1:20]) by stout.grols.ch with esmtp (Exim 4.92) (envelope-from ) id 1nLlFD-0006GW-3y for lkml@grols.ch; Sun, 20 Feb 2022 13:23:15 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234315AbiBTMXE (ORCPT ); Sun, 20 Feb 2022 07:23:04 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231558AbiBTMXE (ORCPT ); Sun, 20 Feb 20 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC0E3CA66 for ; Sun, 20 Feb 2022 04:22:43 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id h125so11912918pgc.3 for ; Sun, 20 Feb 2022 04:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to; bh=R/byEbuYodbqN/dTPHwwxQlwg4dzRor/JniFcuJDSKE=; b=S X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to; bh=R/byEbuYodbqN/dTPHwwxQlwg4dzRor/JniFc X-Gm-Message-State: AOAM531da+h2uguFGKfu9K9XqpYOS+ZIC4VAdqKvj+NxbDGgoADU/ghx cOe+5o349O+b7jSyBnNcCl0= X-Google-Smtp-Source: ABdhPJw/4Aaa7RtOHrKYtjwy7+QQw4VGAuHEaCrTJCc44sCDXC002+58LkOyBdvEfa8p3Gj3lKtPcw== X-Received: by 2002:a63:b50b:0:b0:373:9242:6b98 with SMTP id y11-20020a63b50b000000b0037392426b98mr12466709pge.553.1645359762402; Sun, 20 Feb 2022 04:22:42 -0800 (PST) Received: from ?IPV6:240b:10:2720:5500:2f07:a2ba:6742:b651? ([240b:10:2720:5500:2f07:a2ba:6742:b651]) by smtp.gmail.com with ESMTPSA id 8sm9163488pfl.164.2022.02.20.04.22.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Content-Type: multipart/mixed; boundary="------------400X6pDu0Eno4T3y93R0zub0" Message-Id: <117facba-ba33-349d-1085-25315cc1ae92@gmail.com> Date: Sun, 20 Feb 2022 21:22:35 +0900 Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [BUG] mtd: cfi_cmdset_0002: write regression since v4.17-rc1 Content-Language: en-US From: Tokunori Ikegami To: Ahmad Fatoum , Thorsten Leemhuis , linux-mtd@lists.infradead.org, Joakim.Tjernlund@infinera.com, miquel.raynal@bootlin.com, vigneshr@ti.com, richard@nod.at, "regressions@ Cc: Chris Packham , Brian Norris , David Woodhouse , marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, "linux-kernel@vger.kernel.org" <3dbbcee5-81fc-cdf5-9f8b-b6ccb95beddc@pengutronix.de> <0f2cfcac-83ca-51a9-f92c-ff6495dca1d7@gmail. In-Reply-To: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org Received-SPF: pass client-ip=2620:137:e000::1:20; envelope-from=linux-kernel-owner@vger.kernel.org; helo=out1.vger.email X-Spam-Score: -1.4 X-Spam-Score-Bar: - X-Spam-Action: no action X-Spam-Report: Action: no action Symbol: TO_DN_EQ_ADDR_SOME(0.00) Symbol: RCVD_VIA_SMTP_AUTH(0.00) Symbol: TO_DN_SOME(0.00) Symbol: R_SPF_ALLOW(-0.20) Symbol: FREEMAIL_FROM(0.00) Symbol: HAS_ATTACHMENT(0.00) Symbol: MIME_BASE64_TEXT_BOGUS(1.00) Symbol: DWL_DNSWL_FAIL(0 This is a multi-part message in MIME format. --------------400X6pDu0Eno4T3y93R0zub0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ahmad-san, Could you please try the version 2 patch attached for the error case? This version is to check the DQ true data 0xFF by chip_good(). But I am not sure if this works or not since the error is possible to be caused by Hi-Z 0xff on floating bus or etc. On 2022/02/15 3:46, Tokunori Ikegami wrote: > Hi Ahmad-san, > > On 2022/02/15 1:22, Ahmad Fatoum wrote: >> Hello Tokunori-san, >> >> On 13.02.22 17:47, Tokunori Ikegami wrote: >>> Hi Ahmad-san, >>> >>> Thanks for your confirmations. Sorry for late to reply. >> No worries. I appreciate you taking the time. >> >>> Could you please try the patch attached to disable the chip_good() >>> change as before? >>> I think this should work for S29GL964N since the chip_ready() is >>> used and works as mentioned. >> yes, this resolves my issue: >> Tested-by: Ahmad Fatoum > Thanks for your testing. I have just sent the patch to review. >> >>>>>> Doesn't seem to be a buffered write issue here though as the writes >>>>>> did work fine before dfeae1073583. Any other ideas? >>>>> At first I thought the issue is possible to be resolved by using >>>>> the word write instead of the buffered writes. >>>>> Now I am thinking to disable the changes dfeae1073583 partially >>>>> with any condition if possible. >>>> What seems to work for me is checking if chip_good or chip_ready >>>> and map_word is equal to 0xFF. I can't justify why this is ok though. >>>> (Worst case bus is floating at this point of time and Hi-Z is read >>>> as 0xff on CPU data lines...) >>> Sorry I am not sure about this. >>> I thought the chip_ready() itself is correct as implemented as the >>> data sheet in the past. >>> But it did not work correctly so changed to use chip_good() instead >>> as it is also correct. >> What exactly in the datasheet makes you believe chip_good is not >> appropriate? > I just mentioned about the actual issue behaviors as not worked > chip_good() on S29GL964N and not worked chip_ready() on > MX29GL512FHT2I-11G before etc. > Anyway let me recheck the data sheet details as just checked it again > quickly but needed more investigation to understand. As far as I checked still both chip_good() and chip_ready() seem correct but still the root cause is unknown. If as you mentioned the issue was cased by the DQ true data 0xFF I am not sure why the read work without any error after the write operation. Also if the error was caused by the Hi-Z 0xff on floating bus as mentioned I am not sure why the read work without any error after the write operation with chip_ready(). Sorry anyway the root cause is also unknown when the write operation was changed to use chip_good() instead of chip_ready(). Regards, Ikegami > > Regards, > Ikegami > >> >> Cheers, >> Ahmad >> >> --------------400X6pDu0Eno4T3y93R0zub0 Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-mtd-cfi_cmdset_0002-Change-chip_good-to-check-DQ-.patch" Content-Disposition: attachment; filename*0="v2-0001-mtd-cfi_cmdset_0002-Change-chip_good-to-check-DQ-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyYmVmMDJiZWU4ZmE3NDI3M2NmYzc2NGUyODhiNmY5MmI4NjQ2YmI3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb2t1bm9yaSBJa2VnYW1pIDxpa2VnYW1pLnRAZ21h aWwuY29tPgpEYXRlOiBTYXQsIDE5IEZlYiAyMDIyIDE5OjM5OjMyICswOTAwClN1YmplY3Q6 IFtQQVRDSCB2Ml0gbXRkOiBjZmlfY21kc2V0XzAwMDI6IENoYW5nZSBjaGlwX2dvb2QoKSB0 byBjaGVjayBEUSB0cnVlCiBkYXRhIDB4RkYKClRoZSByZWdyZXNzaW9uIGlzc3VlIGhhcyBi ZWVuIGNhdXNlZCBvbiBTMjlHTDA2NE4gYW5kIHJlcG9ydGVkIGl0LgpUaGUgY2hhbmdlIG1l bnRpb25lZCBmb3IgcmVncmVzc2lvbiBpcyB0byB1c2UgY2hpcF9nb29kKCkgZm9yIGJ1ZmZl cmVkIHdyaXRlLgpBbHNvIGl0IHNlZW1zIHRoYXQgdGhlIDB4RkYgdmFsdWUgaXMgcmVhZCBv biB0aGUgZXJyb3IgY2FzZS4KSXQgaXMgcG9zc2libGUgdG8gYmUgY2F1c2VkIGJ5IERRIHRy dWUgZGF0YSBkZXNjcmliZWQgYnkgUzI5R0wwNjROIGRhdGFzaGVldC4KU28gY2hhbmdlIGNo aXBfZ29vZCgpIHRvIGNoZWNrIERRIHRydWUgZGF0YSAweEZGIGFkZGl0aW9uYWxseSBmb3Ig dGhlIGVycm9yLgoKRml4ZXM6IGRmZWFlMTA3MzU4MygibXRkOiBjZmlfY21kc2V0XzAwMDI6 IENoYW5nZSB3cml0ZSBidWZmZXIgdG8gY2hlY2sgY29ycmVjdCB2YWx1ZSIpClNpZ25lZC1v ZmYtYnk6IFRva3Vub3JpIElrZWdhbWkgPGlrZWdhbWkudEBnbWFpbC5jb20+CkNjOiBsaW51 eC1tdGRAbGlzdHMuaW5mcmFkZWFkLm9yZwpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwpM aW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1tdGQvY2VkYjE2MDQtZTAyNC0y NzM4LTViMzMtMTU3MDNhNjUzODAzQGdtYWlsLmNvbS8KLS0tCiBkcml2ZXJzL210ZC9jaGlw cy9jZmlfY21kc2V0XzAwMDIuYyB8IDI1ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9kcml2ZXJzL210ZC9jaGlwcy9jZmlfY21kc2V0XzAwMDIuYyBiL2RyaXZlcnMv bXRkL2NoaXBzL2NmaV9jbWRzZXRfMDAwMi5jCmluZGV4IGE3NjExMzRmZDNiZS4uMDc5ZjY5 ZTU0MDBkIDEwMDY0NAotLS0gYS9kcml2ZXJzL210ZC9jaGlwcy9jZmlfY21kc2V0XzAwMDIu YworKysgYi9kcml2ZXJzL210ZC9jaGlwcy9jZmlfY21kc2V0XzAwMDIuYwpAQCAtODUzLDcg Kzg1Myw3IEBAIHN0YXRpYyBpbnQgX194aXByYW0gY2hpcF9yZWFkeShzdHJ1Y3QgbWFwX2lu Zm8gKm1hcCwgc3RydWN0IGZsY2hpcCAqY2hpcCwKICAqCiAgKi8KIHN0YXRpYyBpbnQgX194 aXByYW0gY2hpcF9nb29kKHN0cnVjdCBtYXBfaW5mbyAqbWFwLCBzdHJ1Y3QgZmxjaGlwICpj aGlwLAotCQkJICAgICAgdW5zaWduZWQgbG9uZyBhZGRyLCBtYXBfd29yZCBleHBlY3RlZCkK KwkJCSAgICAgIHVuc2lnbmVkIGxvbmcgYWRkciwgbWFwX3dvcmQgKmV4cGVjdGVkKQogewog CXN0cnVjdCBjZmlfcHJpdmF0ZSAqY2ZpID0gbWFwLT5mbGRydl9wcml2OwogCW1hcF93b3Jk IG9sZGQsIGN1cmQ7CkBAIC04NzUsOCArODc1LDEzIEBAIHN0YXRpYyBpbnQgX194aXByYW0g Y2hpcF9nb29kKHN0cnVjdCBtYXBfaW5mbyAqbWFwLCBzdHJ1Y3QgZmxjaGlwICpjaGlwLAog CW9sZGQgPSBtYXBfcmVhZChtYXAsIGFkZHIpOwogCWN1cmQgPSBtYXBfcmVhZChtYXAsIGFk ZHIpOwogCi0JcmV0dXJuCW1hcF93b3JkX2VxdWFsKG1hcCwgb2xkZCwgY3VyZCkgJiYKLQkJ bWFwX3dvcmRfZXF1YWwobWFwLCBjdXJkLCBleHBlY3RlZCk7CisJaWYgKCFtYXBfd29yZF9l cXVhbChtYXAsIG9sZGQsIGN1cmQpKQorCQlyZXR1cm4gMDsKKworCWlmIChleHBlY3RlZCAm JiBtYXBfd29yZF9lcXVhbChtYXAsIGN1cmQsICpleHBlY3RlZCkpCisJCXJldHVybiAxOwor CisJcmV0dXJuIG1hcF93b3JkX2VxdWFsKG1hcCwgb2xkZCwgbWFwX3dvcmRfZmYobWFwKSk7 CiB9CiAKIHN0YXRpYyBpbnQgZ2V0X2NoaXAoc3RydWN0IG1hcF9pbmZvICptYXAsIHN0cnVj dCBmbGNoaXAgKmNoaXAsIHVuc2lnbmVkIGxvbmcgYWRyLCBpbnQgbW9kZSkKQEAgLTE2OTks NyArMTcwNCw3IEBAIHN0YXRpYyBpbnQgX194aXByYW0gZG9fd3JpdGVfb25ld29yZF9vbmNl KHN0cnVjdCBtYXBfaW5mbyAqbWFwLAogCQkgKiAiY2hpcF9nb29kIiB0byBhdm9pZCB0aGUg ZmFpbHVyZSBkdWUgdG8gc2NoZWR1bGluZy4KIAkJICovCiAJCWlmICh0aW1lX2FmdGVyKGpp ZmZpZXMsIHRpbWVvKSAmJgotCQkgICAgIWNoaXBfZ29vZChtYXAsIGNoaXAsIGFkciwgZGF0 dW0pKSB7CisJCSAgICAhY2hpcF9nb29kKG1hcCwgY2hpcCwgYWRyLCAmZGF0dW0pKSB7CiAJ CQl4aXBfZW5hYmxlKG1hcCwgY2hpcCwgYWRyKTsKIAkJCXByaW50ayhLRVJOX1dBUk5JTkcg Ik1URCAlcygpOiBzb2Z0d2FyZSB0aW1lb3V0XG4iLCBfX2Z1bmNfXyk7CiAJCQl4aXBfZGlz YWJsZShtYXAsIGNoaXAsIGFkcik7CkBAIC0xNzA3LDcgKzE3MTIsNyBAQCBzdGF0aWMgaW50 IF9feGlwcmFtIGRvX3dyaXRlX29uZXdvcmRfb25jZShzdHJ1Y3QgbWFwX2luZm8gKm1hcCwK IAkJCWJyZWFrOwogCQl9CiAKLQkJaWYgKGNoaXBfZ29vZChtYXAsIGNoaXAsIGFkciwgZGF0 dW0pKSB7CisJCWlmIChjaGlwX2dvb2QobWFwLCBjaGlwLCBhZHIsICZkYXR1bSkpIHsKIAkJ CWlmIChjZmlfY2hlY2tfZXJyX3N0YXR1cyhtYXAsIGNoaXAsIGFkcikpCiAJCQkJcmV0ID0g LUVJTzsKIAkJCWJyZWFrOwpAQCAtMTk3OSwxNCArMTk4NCwxNCBAQCBzdGF0aWMgaW50IF9f eGlwcmFtIGRvX3dyaXRlX2J1ZmZlcl93YWl0KHN0cnVjdCBtYXBfaW5mbyAqbWFwLAogCQkg KiAiY2hpcF9nb29kIiB0byBhdm9pZCB0aGUgZmFpbHVyZSBkdWUgdG8gc2NoZWR1bGluZy4K IAkJICovCiAJCWlmICh0aW1lX2FmdGVyKGppZmZpZXMsIHRpbWVvKSAmJgotCQkgICAgIWNo aXBfZ29vZChtYXAsIGNoaXAsIGFkciwgZGF0dW0pKSB7CisJCSAgICAhY2hpcF9nb29kKG1h cCwgY2hpcCwgYWRyLCAmZGF0dW0pKSB7CiAJCQlwcl9lcnIoIk1URCAlcygpOiBzb2Z0d2Fy ZSB0aW1lb3V0LCBhZGRyZXNzOjB4JS44bHguXG4iLAogCQkJICAgICAgIF9fZnVuY19fLCBh ZHIpOwogCQkJcmV0ID0gLUVJTzsKIAkJCWJyZWFrOwogCQl9CiAKLQkJaWYgKGNoaXBfZ29v ZChtYXAsIGNoaXAsIGFkciwgZGF0dW0pKSB7CisJCWlmIChjaGlwX2dvb2QobWFwLCBjaGlw LCBhZHIsICZkYXR1bSkpIHsKIAkJCWlmIChjZmlfY2hlY2tfZXJyX3N0YXR1cyhtYXAsIGNo aXAsIGFkcikpCiAJCQkJcmV0ID0gLUVJTzsKIAkJCWJyZWFrOwpAQCAtMjI4Miw3ICsyMjg3 LDcgQEAgc3RhdGljIGludCBkb19wYW5pY193cml0ZV9vbmV3b3JkKHN0cnVjdCBtYXBfaW5m byAqbWFwLCBzdHJ1Y3QgZmxjaGlwICpjaGlwLAogCQl1ZGVsYXkoMSk7CiAJfQogCi0JaWYg KCFjaGlwX2dvb2QobWFwLCBjaGlwLCBhZHIsIGRhdHVtKSB8fAorCWlmICghY2hpcF9nb29k KG1hcCwgY2hpcCwgYWRyLCAmZGF0dW0pIHx8CiAJICAgIGNmaV9jaGVja19lcnJfc3RhdHVz KG1hcCwgY2hpcCwgYWRyKSkgewogCQkvKiByZXNldCBvbiBhbGwgZmFpbHVyZXMuICovCiAJ CW1hcF93cml0ZShtYXAsIENNRCgweEYwKSwgY2hpcC0+c3RhcnQpOwpAQCAtMjQ3OCw3ICsy NDgzLDcgQEAgc3RhdGljIGludCBfX3hpcHJhbSBkb19lcmFzZV9jaGlwKHN0cnVjdCBtYXBf aW5mbyAqbWFwLCBzdHJ1Y3QgZmxjaGlwICpjaGlwKQogCQkJY2hpcC0+ZXJhc2Vfc3VzcGVu ZGVkID0gMDsKIAkJfQogCi0JCWlmIChjaGlwX2dvb2QobWFwLCBjaGlwLCBhZHIsIG1hcF93 b3JkX2ZmKG1hcCkpKSB7CisJCWlmIChjaGlwX2dvb2QobWFwLCBjaGlwLCBhZHIsIE5VTEwp KSB7CiAJCQlpZiAoY2ZpX2NoZWNrX2Vycl9zdGF0dXMobWFwLCBjaGlwLCBhZHIpKQogCQkJ CXJldCA9IC1FSU87CiAJCQlicmVhazsKQEAgLTI1NzcsNyArMjU4Miw3IEBAIHN0YXRpYyBp bnQgX194aXByYW0gZG9fZXJhc2Vfb25lYmxvY2soc3RydWN0IG1hcF9pbmZvICptYXAsIHN0 cnVjdCBmbGNoaXAgKmNoaXAsCiAJCQljaGlwLT5lcmFzZV9zdXNwZW5kZWQgPSAwOwogCQl9 CiAKLQkJaWYgKGNoaXBfZ29vZChtYXAsIGNoaXAsIGFkciwgbWFwX3dvcmRfZmYobWFwKSkp IHsKKwkJaWYgKGNoaXBfZ29vZChtYXAsIGNoaXAsIGFkciwgTlVMTCkpIHsKIAkJCWlmIChj ZmlfY2hlY2tfZXJyX3N0YXR1cyhtYXAsIGNoaXAsIGFkcikpCiAJCQkJcmV0ID0gLUVJTzsK IAkJCWJyZWFrOwotLSAKMi4zMi4wCgo= --------------400X6pDu0Eno4T3y93R0zub0--