lkml.org 
[lkml]   [2022]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 14/32] mtd: spi-nor: winbond: unify function names
Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on mtd/spi-nor/next]
[also build test WARNING on tip/master linux/master linus/master v5.17-rc4 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Michael-Walle/mtd-spi-nor-move-vendor-specific-code-into-vendor-modules/20220220-192832
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
config: alpha-randconfig-r034-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210301.BeYSA7Ny-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c09cbfe090ed6015773211aad1bd2387dd958b7a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Michael-Walle/mtd-spi-nor-move-vendor-specific-code-into-vendor-modules/20220220-192832
git checkout c09cbfe090ed6015773211aad1bd2387dd958b7a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/mtd/spi-nor/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/mtd/spi-nor/winbond.c:141: warning: expecting prototype for winbond_set_4byte_addr_mode(). Prototype was for winbond_nor_set_4byte_addr_mode() instead


vim +141 drivers/mtd/spi-nor/winbond.c

7b8b22010af95f Boris Brezillon 2020-03-13 131
7b8b22010af95f Boris Brezillon 2020-03-13 132 /**
7b8b22010af95f Boris Brezillon 2020-03-13 133 * winbond_set_4byte_addr_mode() - Set 4-byte address mode for Winbond flashes.
7b8b22010af95f Boris Brezillon 2020-03-13 134 * @nor: pointer to 'struct spi_nor'.
7b8b22010af95f Boris Brezillon 2020-03-13 135 * @enable: true to enter the 4-byte address mode, false to exit the 4-byte
7b8b22010af95f Boris Brezillon 2020-03-13 136 * address mode.
7b8b22010af95f Boris Brezillon 2020-03-13 137 *
7b8b22010af95f Boris Brezillon 2020-03-13 138 * Return: 0 on success, -errno otherwise.
7b8b22010af95f Boris Brezillon 2020-03-13 139 */
c09cbfe090ed60 Michael Walle 2022-02-18 140 static int winbond_nor_set_4byte_addr_mode(struct spi_nor *nor, bool enable)
7b8b22010af95f Boris Brezillon 2020-03-13 @141 {
7b8b22010af95f Boris Brezillon 2020-03-13 142 int ret;
7b8b22010af95f Boris Brezillon 2020-03-13 143
7b8b22010af95f Boris Brezillon 2020-03-13 144 ret = spi_nor_set_4byte_addr_mode(nor, enable);
7b8b22010af95f Boris Brezillon 2020-03-13 145 if (ret || enable)
7b8b22010af95f Boris Brezillon 2020-03-13 146 return ret;
7b8b22010af95f Boris Brezillon 2020-03-13 147
7b8b22010af95f Boris Brezillon 2020-03-13 148 /*
7b8b22010af95f Boris Brezillon 2020-03-13 149 * On Winbond W25Q256FV, leaving 4byte mode causes the Extended Address
7b8b22010af95f Boris Brezillon 2020-03-13 150 * Register to be set to 1, so all 3-byte-address reads come from the
7b8b22010af95f Boris Brezillon 2020-03-13 151 * second 16M. We must clear the register to enable normal behavior.
7b8b22010af95f Boris Brezillon 2020-03-13 152 */
7b8b22010af95f Boris Brezillon 2020-03-13 153 ret = spi_nor_write_enable(nor);
7b8b22010af95f Boris Brezillon 2020-03-13 154 if (ret)
7b8b22010af95f Boris Brezillon 2020-03-13 155 return ret;
7b8b22010af95f Boris Brezillon 2020-03-13 156
7b8b22010af95f Boris Brezillon 2020-03-13 157 ret = spi_nor_write_ear(nor, 0);
7b8b22010af95f Boris Brezillon 2020-03-13 158 if (ret)
7b8b22010af95f Boris Brezillon 2020-03-13 159 return ret;
7b8b22010af95f Boris Brezillon 2020-03-13 160
7b8b22010af95f Boris Brezillon 2020-03-13 161 return spi_nor_write_disable(nor);
7b8b22010af95f Boris Brezillon 2020-03-13 162 }
7b8b22010af95f Boris Brezillon 2020-03-13 163

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-09-17 16:14    [W:0.152 / U:23.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site