Messages in this thread | | | Date | Sun, 20 Feb 2022 18:32:59 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH 1/2] random: fix locking in crng_fast_load() |
| |
On Sat, Feb 05, 2022 at 11:34:57AM +0100, Dominik Brodowski wrote: > crng_init is protected by primary_crng->lock, so keep holding that lock > when incrementing crng_init from 0 to 1 in crng_fast_load(). The call to > pr_notice() can wait until the lock is released; this code path cannot > be reached twice, as crng_fast_load() aborts early if crng_init > 0. > > Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> > --- > drivers/char/random.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
| |