Messages in this thread | | | Date | Thu, 3 Feb 2022 06:19:18 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 2/8] VMCI: dma dg: add MMIO access to registers |
| |
Hi Jorgen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on linux/master linus/master v5.17-rc2 next-20220202] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 7ab004dbcbee38b8a70798835d3ffcd97a985a5e config: i386-randconfig-a013-20220131 (https://download.01.org/0day-ci/archive/20220203/202202030643.4ehOD5SG-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6b1e844b69f15bb7dffaf9365cd2b355d2eb7579) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/f2afd39bab80c2e42ac789f6d949d779411df928 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jorgen-Hansen/VMCI-dma-dg-Add-support-for-DMA-datagrams/20220202-230034 git checkout f2afd39bab80c2e42ac789f6d949d779411df928 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/misc/vmw_vmci/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/vmw_vmci/vmci_guest.c:93:14: warning: no previous prototype for function 'vmci_read_reg' [-Wmissing-prototypes] unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg) ^ drivers/misc/vmw_vmci/vmci_guest.c:93:1: note: declare 'static' if the function is not intended to be used outside of this translation unit unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg) ^ static >> drivers/misc/vmw_vmci/vmci_guest.c:100:6: warning: no previous prototype for function 'vmci_write_reg' [-Wmissing-prototypes] void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg) ^ drivers/misc/vmw_vmci/vmci_guest.c:100:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg) ^ static 2 warnings generated.
vim +/vmci_read_reg +93 drivers/misc/vmw_vmci/vmci_guest.c
92 > 93 unsigned int vmci_read_reg(struct vmci_guest_device *dev, u32 reg) 94 { 95 if (dev->mmio_base != NULL) 96 return readl(dev->mmio_base + reg); 97 return ioread32(dev->iobase + reg); 98 } 99 > 100 void vmci_write_reg(struct vmci_guest_device *dev, u32 val, u32 reg) 101 { 102 if (dev->mmio_base != NULL) 103 writel(val, dev->mmio_base + reg); 104 else 105 iowrite32(val, dev->iobase + reg); 106 } 107
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
| |