Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCHv2 11/29] x86/boot: Allow to hook up alternative port I/O helpers | Date | Wed, 02 Feb 2022 20:05:02 +0100 |
| |
On Wed, Feb 02 2022 at 20:20, Kirill A. Shutemov wrote: > On Tue, Feb 01, 2022 at 11:53:28PM +0100, Thomas Gleixner wrote: >> Can we please make that u8, u16, u32 instead of unsigned char,short,int? >> >> That's the kernel convention for hardware related functions for many >> years now. > > I inherited these prototypes from the main kernel I/O helpers. See patch > 10/29. > > Do you want 10/29 to be changed to use u8/16/32? > > Maybe a separate patch to convert main kernel to u8/16/32 before > consolidation with boot stub?
Yes, please. That aligns them also with the asm-generic/io.h implementation.
Thanks,
tglx
| |