Messages in this thread | | | Date | Wed, 2 Feb 2022 17:38:27 +0100 | Subject | Re: [PATCHv2 7/7] nvme: add support for enhanced metadata | From | Hannes Reinecke <> |
| |
On 2/2/22 16:41, Keith Busch wrote: > On Wed, Feb 02, 2022 at 02:28:53PM +0100, Hannes Reinecke wrote: >> On 2/1/22 20:01, Keith Busch wrote: [ .. ] >>> @@ -3104,7 +3218,7 @@ int nvme_init_ctrl_finish(struct nvme_ctrl *ctrl) >>> if (ret < 0) >>> return ret; >>> - ret = nvme_configure_acre(ctrl); >>> + ret = nvme_configure_host_options(ctrl); >>> if (ret < 0) >>> return ret; >> >> This could be made into a separate patch, is it's not directly related to PI >> support. > > Well, the driver can't read the new PI formats without enabling host > supported features for it. Enabling the feature tells the controller > we're going to check for it, so I don't think we could reasonably split > this part into a prep patch from the part that sets up the PI formats.
Actually I was thinking about a patch renaming 'nvme_configure_acre' into 'nvme_configure_host_options', as _this_ really is independent. When mixed together with the PI stuff it's hard to track down from the commit message when it got changed.
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
| |