Messages in this thread | | | Subject | Re: [PATCH] selftests: fixup build warnings in pidfd / clone3 tests | From | Shuah Khan <> | Date | Wed, 2 Feb 2022 08:53:49 -0700 |
| |
On 1/28/22 1:57 AM, Christian Brauner wrote: > On Thu, Jan 27, 2022 at 02:11:15PM -0800, Axel Rasmussen wrote: >> These are some trivial fixups, which were needed to build the tests with >> clang and -Werror. The following issues are fixed: >> >> - Remove various unused variables. >> - In child_poll_leader_exit_test, clang isn't smart enough to realize >> syscall(SYS_exit, 0) won't return, so it complains we never return >> from a non-void function. Add an extra exit(0) to appease it. >> - In test_pidfd_poll_leader_exit, ret may be branched on despite being >> uninitialized, if we have !use_waitpid. Initialize it to zero to get >> the right behavior in that case. >> >> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com> >> --- > > Thanks! > (Fwiw, all those tests should also be ported to use the TEST_*() harness > infra. Currently it's an annoying mix.) > Acked-by: Christian Brauner <brauner@kernel.org> >
Yes. Porting would be great. I will take this for now for 5.17-rc4
thanks, -- Shuah
| |