lkml.org 
[lkml]   [2022]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/31] media: v4l2-core: changing LED_* from enum led_brightness to actual value
    Hi Luiz,

    On Fri, Jan 21, 2022 at 01:54:17PM -0300, Luiz Sampaio wrote:
    > The enum led_brightness, which contains the declaration of LED_OFF,
    > LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
    > max_brightness.

    The set appears to be missing the Signed-off-by: line, at least in the
    three patches cc'd to the linux-media list.

    With this fixed, for this patch:

    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

    > ---
    > drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c
    > index e70e128ccc9c..a47ac654c9f4 100644
    > --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c
    > +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c
    > @@ -234,11 +234,11 @@ static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c)
    > case V4L2_CID_FLASH_LED_MODE:
    > switch (c->val) {
    > case V4L2_FLASH_LED_MODE_NONE:
    > - led_set_brightness_sync(led_cdev, LED_OFF);
    > + led_set_brightness_sync(led_cdev, 0);
    > return led_set_flash_strobe(fled_cdev, false);
    > case V4L2_FLASH_LED_MODE_FLASH:
    > /* Turn the torch LED off */
    > - led_set_brightness_sync(led_cdev, LED_OFF);
    > + led_set_brightness_sync(led_cdev, 0);
    > if (ctrls[STROBE_SOURCE]) {
    > external_strobe = (ctrls[STROBE_SOURCE]->val ==
    > V4L2_FLASH_STROBE_SOURCE_EXTERNAL);

    --
    Regards,

    Sakari Ailus

    \
     
     \ /
      Last update: 2022-02-02 13:55    [W:3.797 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site