lkml.org 
[lkml]   [2022]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] arm64: dts: rockchip: Add Pine64 PineNote board
From


On 2/2/22 11:41, Johan Jonker wrote:
> Hi Samuel,

> On 1/30/22 06:38, Samuel Holland wrote:

>> +/ {
>> + aliases {

>> + mmc0 = &sdhci;

sdmmc1 ??

MMC aliases should be sort on reg address, based on availability and
without number gap.

>> + };
>> +

[..]

>> +&sdhci {
>> + bus-width = <8>;
>> + mmc-hs200-1_8v;
>> + non-removable;
>> + pinctrl-0 = <&emmc_bus8>, <&emmc_clk>, <&emmc_cmd>, <&emmc_datastrobe>, <&emmc_rstnout>;
>> + pinctrl-names = "default";
>> + vmmc-supply = <&vcc_3v3>;
>> + vqmmc-supply = <&vcc_1v8>;
>> + status = "okay";
>> +};
>> +
>> +&sdmmc1 {
>> + bus-width = <4>;
>> + cap-sd-highspeed;
>> + cap-sdio-irq;
>
>> + disable-wp;
>
> From mmc-controller.yaml:
>
> disable-wp:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> When set, no physical write-protect line is present. This
> property should only be specified when the controller has a
> dedicated write-protect detection logic. If a GPIO is always used
> for the write-protect detection logic, it is sufficient to not
> specify the wp-gpios property in the absence of a write-protect
> line. Not used in combination with eMMC or SDIO.
>
>> + keep-power-in-suspend;
>> + mmc-pwrseq = <&sdio_pwrseq>;
>> + non-removable;
>> + pinctrl-0 = <&sdmmc1_bus4>, <&sdmmc1_clk>, <&sdmmc1_cmd>;
>> + pinctrl-names = "default";
>> + sd-uhs-sdr104;
>> + vmmc-supply = <&vcc_wl>;
>> + vqmmc-supply = <&vcca_1v8_pmu>;
>> + status = "okay";
>> +};
>> +

\
 
 \ /
  Last update: 2022-02-02 12:02    [W:0.046 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site