lkml.org 
[lkml]   [2022]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] soc: renesas: Add support for reading product revision for RZ/G2L family
Date
Hi Geert,

> Subject: Re: [PATCH v2] soc: renesas: Add support for reading product
> revision for RZ/G2L family
>
> Hi Prabhakar,
>
> On Fri, Jan 21, 2022 at 2:41 AM Lad Prabhakar <prabhakar.mahadev-
> lad.rj@bp.renesas.com> wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > As per RZ/G2L HW manual (Rev.1.00 Sep, 2021) DEV_ID [31:28] indicates
> > product revision. Use this information to populate the revision info
> > for RZ/G2L family.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v1->v2
> > * Fixed freeing up soc_dev_attr in error path.
>
> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
> in renesas-devel for v5.18.
>
> > --- a/drivers/soc/renesas/renesas-soc.c
> > +++ b/drivers/soc/renesas/renesas-soc.c
> > @@ -405,41 +417,38 @@ static int __init renesas_soc_init(void)
> >
> > eshi = ((product >> 4) & 0x0f) + 1;
> > eslo = product & 0xf;
> > + soc_dev_attr->revision = kasprintf(GFP_KERNEL,
> "ES%u.%u",
> > + eshi, eslo);
> > + } else if (id == &id_rzg2l) {
> > + eshi = ((product >> 28) & 0x0f);
> > + soc_dev_attr->revision = kasprintf(GFP_KERNEL,
> "Rev %u",
> > + eshi);
>
> Would you mind if I would drop the "Rev " while applying?

Kernel reports the below message after dropping Rev. Is it OK?

[ 0.018297] Detected Renesas RZ/G2L r9a07g044 1

Cheers,
Biju
\
 
 \ /
  Last update: 2022-02-02 10:51    [W:0.097 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site