Messages in this thread | | | Date | Wed, 2 Feb 2022 18:34:43 -0600 | Subject | Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() | From | "Madhavan T. Venkataraman" <> |
| |
On 2/2/22 12:46, Mark Brown wrote: > On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com> >> >> Rename the arguments to unwind() for better consistency. Also, use the >> typedef stack_trace_consume_fn for the consume_entry function as it is >> already defined in linux/stacktrace.h. > > Consistency with...? But otherwise:
Naming consistency. E.g., the name consume_entry is used in a lot of places. This code used to use fn() instead of consume_entry(). arch_stack_walk() names the argument to consume_entry as cookie. This code calls it data instead of cookie. That is all. It is minor in nature. But I thought I might as well make it conform while I am at it.
Madhavan
| |