Messages in this thread | | | Date | Wed, 2 Feb 2022 16:05:31 -0800 | From | Luis Chamberlain <> | Subject | Re: [PATCH v3 0/6] Allocate module text and data separately |
| |
On Sat, Jan 29, 2022 at 05:02:03PM +0000, Christophe Leroy wrote: > This series allow architectures to request having modules data in > vmalloc area instead of module area. > > This is required on powerpc book3s/32 in order to set data non > executable, because it is not possible to set executability on page > basis, this is done per 256 Mbytes segments. The module area has exec > right, vmalloc area has noexec. Without this change module data > remains executable regardless of CONFIG_STRICT_MODULES_RWX. > > This can also be useful on other powerpc/32 in order to maximize the > chance of code being close enough to kernel core to avoid branch > trampolines. >
This looks good, however I'd like to see Aaron's changes go in first, and then yours. Aaron's changes still need to be tested by 0-day and I need to finish review, but that's the order of how I'd prefer to see changes merged / tested. I'll try to review his changes, dump them to modules-next and then I'd like to trouble you to rebase ontop of that.
We should get all this tested early for the next release.
Luis
| |