lkml.org 
[lkml]   [2022]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/22] mmc: wbsd: Use dma_alloc_noncoherent() for dma buffer
On Sat, Feb 19, 2022 at 08:52:20AM +0800, Baoquan He wrote:
> if (request_dma(dma, DRIVER_NAME))
> goto err;
>
> + dma_set_mask_and_coherent(mmc_dev(host->mmc), DMA_BIT_MASK(24));

This also sets the streaming mask, but the driver doesn't seem to make
use of that. Please document it in the commit log.

Also setting smaller than 32 bit masks can fail, so this should have
error handling.

\
 
 \ /
  Last update: 2022-02-19 08:19    [W:1.118 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site