Messages in this thread | | | Subject | Re: [PATCH v3 4/5] selftests/resctrl: Change the default limited time to 120 seconds | From | Shuah Khan <> | Date | Fri, 18 Feb 2022 13:32:24 -0700 |
| |
On 2/15/22 7:26 PM, Shaopeng Tan wrote: > When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl > selftests fail due to timeout after exceeding the default time limit of > 45 seconds. On this system the test takes about 68 seconds. > Since the failing test by default accesses a fixed size of memory, the > execution time should not vary significantly between different environment. > A new default of 120 seconds should be sufficient yet easy to customize > with the introduction of the "settings" file for reference. > > Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > --- > From the perspective of the kselftest framework, > a rule of "Don't take too long" is a concern. > To get some better informed opinions from kselftest audience, > I highlighted this change in the cover letter. > > I adopted most of Reinette's phrase from the discussion in patch v2 > to explain why 120s is appropriate for this test. > > tools/testing/selftests/resctrl/settings | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tools/testing/selftests/resctrl/settings > > diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings > new file mode 100644 > index 000000000000..6091b45d226b > --- /dev/null > +++ b/tools/testing/selftests/resctrl/settings > @@ -0,0 +1 @@ > +timeout=120 >
This is fine.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |