Messages in this thread | | | Date | Fri, 18 Feb 2022 14:23:01 -0500 | From | Steven Rostedt <> | Subject | Re: [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges |
| |
On Fri, 18 Feb 2022 18:46:29 +0000 Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, Feb 18, 2022 at 01:09:20PM -0500, Steven Rostedt wrote: > > Please indent the above better. That is: > > > > __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) > > + (merge_next == AV_MERGE_DIFFERENT) > > + (merge_both == AV_MERGE_DIFFERENT); > > I thought our coding style preferred trailing operators; that is: > > __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) + > (merge_next == AV_MERGE_DIFFERENT) + > (merge_both == AV_MERGE_DIFFERENT);
I'm OK with either. I just can't handle the original.
-- Steve
| |