lkml.org 
[lkml]   [2022]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] input: Add Marine Navigation Keycodes
Hi Shelby,

On Wed, Jan 26, 2022 at 03:12:24PM -0600, Shelby Heffron wrote:
> Add keycodes that are used by marine navigation devices
>
> Signed-off-by: Shelby Heffron <Shelby.Heffron@garmin.com>
> ---
> include/uapi/linux/input-event-codes.h | 28 ++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 225ec87d4f22..26b6a2f482ab 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -660,6 +660,34 @@
> /* Select an area of screen to be copied */
> #define KEY_SELECTIVE_SCREENSHOT 0x27a
>
> +/* Toggle the focus in or out */
> +#define KEY_FOCUS_TOGGLE 0x27b

Could it be served by KEY_SELECT?

> +
> +/* Move between highlightable items */
> +#define KEY_NEXT_HIGHLIGHT 0x27c
> +#define KEY_PREVIOUS_HIGHLIGHT 0x27d

I wonder if KEY_NEXT and KEY_PREVIOUS would be suitable for your
application.

> +
> +/* Toggle Autopilot enagement */
> +#define KEY_AUTOPILOT_ENGAGE_TOGGLE 0x27e
> +
> +/* Navigate Displays */
> +#define KEY_NEXT_DISPLAY 0x27f
> +#define KEY_PREVIOUS_DISPLAY 0x280

I am not familiar with marine navigation devices, could you please
explain a bit more about displays you are navigating. Are there separate
physical screens or are there several application screens/views you are
switching between?

> +
> +/* Shortcut Keys */
> +#define KEY_MARK_WAYPOINT 0x281
> +#define KEY_SOS 0x282
> +#define KEY_NAV_CHART 0x283
> +#define KEY_FISHING_CHART 0x284
> +#define KEY_SINGLE_RANGE_RADAR 0x285
> +#define KEY_DUAL_RANGE_RADAR 0x286
> +#define KEY_RADAR_OVERLAY 0x287
> +#define KEY_TRADITIONAL_SONAR 0x288
> +#define KEY_CLEARVU_SONAR 0x289
> +#define KEY_SIDEVU_SONAR 0x28a
> +#define KEY_NAV_INFO 0x28b

This are fine I believe.

> +#define KEY_BRIGHTNESS_MENU 0x28c

Do you have multiple menus in the application?

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2022-02-18 08:03    [W:0.364 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site