Messages in this thread | | | Date | Fri, 18 Feb 2022 14:56:30 +0100 | From | Martin Kaiser <> | Subject | Re: [PATCH RFC] staging: r8188eu: comment about the chip's packet format |
| |
Thus wrote Dan Carpenter (dan.carpenter@oracle.com):
> On Fri, Feb 18, 2022 at 10:22:53AM +0100, Martin Kaiser wrote:
> > Would it make sense to add a word of warning to prevent others from > > repeating this exercise?
> Just the fact that these structs are endian means they're from the > firmware or the network.
> If a struct has a pointer in it, then it's rarely part of the UAPI but > if it has endian data then it probably is.
ah, these are useful criteria, thanks. I see that the comment isn't really necessary...
| |