Messages in this thread | | | Date | Fri, 18 Feb 2022 14:17:57 +0100 | Subject | Re: [PATCH v1 3/7] powercap/dtpm: Fixup kfree for virtual node | From | Daniel Lezcano <> |
| |
On 17/02/2022 16:45, Ulf Hansson wrote:
[ ... ]
> Does ops->release() also resets the "dtpm" pointer to NULL? If not, > it's good practice that it should, right? > > In that case, we would be calling "kfree(NULL);" the second time, > which is perfectly fine.
So you suggest to replace:
if (ops->release) ops->release(dtpm); else kfree(dtpm);
By:
if (ops->release) { ops->release(dtpm); dtpm = NULL; }
kfree(dtpm);
?
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |