lkml.org 
[lkml]   [2022]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] media: cx18: use GFP_KERNEL
On Thu, Feb 10, 2022 at 09:42:16PM +0100, Julia Lawall wrote:
> Pci_driver probe functions aren't called with locks held
> and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
>
> Problem found with Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> drivers/media/pci/cx18/cx18-driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/cx18/cx18-driver.c b/drivers/media/pci/cx18/cx18-driver.c
> index 59497ba6bf1f..1be9672ae9d4 100644
> --- a/drivers/media/pci/cx18/cx18-driver.c
> +++ b/drivers/media/pci/cx18/cx18-driver.c
> @@ -899,7 +899,7 @@ static int cx18_probe(struct pci_dev *pci_dev,
> return -ENOMEM;

Unrelated to your patch but every error path in this function ought to
call atomic_dec(&cx18_instance);

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-02-18 13:29    [W:0.233 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site