Messages in this thread | | | Subject | Re: [PATCH -next v3 0/2] jffs2: fix two memory leak when mount jffs2 | From | "libaokun (A)" <> | Date | Fri, 18 Feb 2022 14:14:16 +0800 |
| |
在 2022/1/14 18:28, Baokun Li 写道:
ping
> V1->V2: > In jffs2_scan_medium, > if s = kzalloc(sizeof(struct jffs2_summary), GFP_KERNEL); > returns error, go to "out" to do clear. Null pointer dereference > occurs when if (s->sum_list_head) is executed in "out". > > V2->V3: > Sorry for the noise, but there seems to be a more elegant way to > fix the memory leak in jffs2_scan_medium. When memory allocation > fails or CONFIG_JFFS2_SUMMARY is N, s is NULL.For the former case, > add the new tag "out_buf" to avoid it.In the latter case, > jffs2_sum_reset_collected is also an empty function and does nothing. > > Baokun Li (2): > jffs2: fix memory leak in jffs2_do_mount_fs > jffs2: fix memory leak in jffs2_scan_medium > > fs/jffs2/build.c | 4 +++- > fs/jffs2/scan.c | 6 ++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) >
| |