Messages in this thread Patch in this message | | | From | Martin Kaiser <> | Subject | [PATCH RFC] staging: r8188eu: comment about the chip's packet format | Date | Fri, 18 Feb 2022 10:22:53 +0100 |
| |
The structs phy_rx_agc_info and phy_status_rpt define parts of the header data that the r8188eu chipset sends to this driver via usb.
Add a comment to clarify that we cannot modify the content of these structures and remove seemingly unused fields.
Signed-off-by: Martin Kaiser <martin@kaiser.cx> ---
Dear all,
I experimented with "cleaning up" these structures and related code before discovering that their content comes from usb packets we receive from the r8188eu chipset.
Would it make sense to add a word of warning to prevent others from repeating this exercise?
Thanks, Martin
drivers/staging/r8188eu/include/odm_HWConfig.h | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/staging/r8188eu/include/odm_HWConfig.h b/drivers/staging/r8188eu/include/odm_HWConfig.h index b37962edb2ed..35a562372a1a 100644 --- a/drivers/staging/r8188eu/include/odm_HWConfig.h +++ b/drivers/staging/r8188eu/include/odm_HWConfig.h @@ -14,6 +14,13 @@ /* structure and define */ +/* + * Attention: struct phy_status_rpt and struct phy_rx_agc_info describe + * data structures that this driver receives from the r8188eu chip via usb. + * Do not change the content of these structures, do not remove seemingly + * unused entries. + */ + struct phy_rx_agc_info { #ifdef __LITTLE_ENDIAN u8 gain:7, trsw:1; -- 2.30.2
| |