Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 18 Feb 2022 09:44:06 +0100 | Subject | Re: [PATCH] i2c: riic: Simplify reset handling |
| |
On Thu, Feb 10, 2022 at 12:22 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Read reset phandle as optional instead of exclusive so that all the DT's > passing the reset phandle can be used to assert/deassert the reset line. > With this change we don't have to differentiate the RZ/G2L SoC. > > With the above changes we no longer need the "renesas,riic-r9a07g044" > compatible string, so drop it from riic_i2c_dt_ids[]. No changes are > required to the r9a07g044.dtsi as we already have "renesas,riic-rz" as a > fallback compatible string. > > While at it, check the return code of reset_control_deassert() as it might > fail and also add a devres action to assert the reset line. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |