Messages in this thread | | | Subject | Re: [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support | From | Shuah Khan <> | Date | Fri, 18 Feb 2022 17:27:41 -0700 |
| |
On 2/16/22 12:35 AM, Huang Rui wrote: > Hi Shuah, > > Since AMD P-State kernel is merged into 5.17-rc1, I would like to continue > revising the AMD P-State support for the CPUPower tool. These series are > rebased on latest bleeding-edge, any comments are warm for me. > > See patch series of CPUPower in below git repo: > V1: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v1 > V2: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v2 > V3: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v3 > V4: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v4 > V5: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v5 > V6: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=cpupower-amd-pstate >
A few checkpatch warns to fix. I usually ignore CHECK from checkpatch, but a few of them found on this series could improve the code.
Also is there a need to add/update manpages and documentation.
I tested these my AMD Ryzen 7 4700G system. I didn't play with set commands and just the info ones.
cpupower info gave me this output. The first message is fine, but the second one is a bit odd. Should it just bail out right after the first message about "not support"
cpupower info
System does not support Intel's performance bias setting analyzing CPU 0:
Go ahead send me v7 for these and add any mapages/doc if necessary. I will get them into Linux 5.18-rc1
thanks, -- Shuah
| |