Messages in this thread | | | Date | Fri, 18 Feb 2022 08:47:51 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] counter: Stop using dev_get_drvdata() to get the counter device |
| |
Hello,
On Fri, Feb 18, 2022 at 08:42:51AM +0900, William Breathitt Gray wrote: > On Thu, Feb 17, 2022 at 05:03:08PM +0100, Uwe Kleine-König wrote: > > On Thu, Feb 17, 2022 at 04:48:50PM +0200, Jarkko Nikula wrote: > > > On 2/8/22 03:42, William Breathitt Gray wrote: > > > > On Fri, Feb 04, 2022 at 09:25:56AM +0100, Uwe Kleine-König wrote: > > > > > dev_get_drvdata() returns NULL since commit b56346ddbd82 ("counter: Use > > > > > container_of instead of drvdata to track counter_device") which wrongly > > > > > claimed there were no users of drvdata. Convert to container_of() to > > > > > fix a null pointer dereference. > > > > > > > > > > Reported-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > > > Fixes: b56346ddbd82 ("counter: Use container_of instead of drvdata to track counter_device") > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > > > > > I'll pick this up and apply it to my tree. > > > > > > Perhaps late but I hit this same issue, patch here fixes it and I wanted to > > > confirm it. > > > > > > Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > > > > I wonder if this patch is scheduled for 5.17. Currently it's not even in > > next ... :-\ > > I've got it in my tree. I'm sending a pull request for the Counter > patches for 5.17 next week, so they should all be merged after that.
That's good. Still I think you could make live easier for your users to find fixes if your tree was included in next. And in MAINTAINERS.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |