Messages in this thread | | | Date | Thu, 17 Feb 2022 13:58:01 +0000 (GMT) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH] MIPS: remove asm/war.h |
| |
On Thu, 17 Feb 2022, Thomas Bogendoerfer wrote:
> diff --git a/arch/mips/kernel/r4k-bugs64.c b/arch/mips/kernel/r4k-bugs64.c > index 35729c9e6cfa..11392e40d034 100644 > --- a/arch/mips/kernel/r4k-bugs64.c > +++ b/arch/mips/kernel/r4k-bugs64.c > @@ -163,7 +163,8 @@ static __always_inline __init void check_mult_sh(void) > } > > pr_cont("no.\n"); > - panic(bug64hit, !R4000_WAR ? r4kwar : nowar); > + panic(bug64hit, !IS_ENABLED(CONFIG_CPU_R4000_WORKAROUNDS) ? r4kwar : > + nowar);
I think it'll read better if formatted like this:
panic(bug64hit, !IS_ENABLED(CONFIG_CPU_R4000_WORKAROUNDS) ? r4kwar : nowar);
or without the negation even:
panic(bug64hit, IS_ENABLED(CONFIG_CPU_R4000_WORKAROUNDS) ? nowar : r4kwar);
Likewise throughout.
Maciej
| |