Messages in this thread | | | Date | Thu, 17 Feb 2022 13:52:47 +0200 | Subject | Re: [PATCH net-next v2 0/2] flow_offload: add tc police parameters | From | Roi Dayan <> |
| |
On 2022-02-17 1:34 PM, Simon Horman wrote: > On Thu, Feb 17, 2022 at 08:28:01AM +0000, Jianbo Liu wrote: >> As a preparation for more advanced police offload in mlx5 (e.g., >> jumping to another chain when bandwidth is not exceeded), extend the >> flow offload API with more tc-police parameters. Adjust existing >> drivers to reject unsupported configurations. > > Hi, > > I have a concern that > a) patch 1 introduces a facility that may break existing drivers; and > b) patch 2 then fixes this > > I'd slightly prefer if the series was rearranged to avoid this problem. > > ...
Hi Simon,
It can't be rearranged as patch 2 can't compile without patch 1. Patch 1 only adds more information passing to the driver.
The drivers functionality doesn't change. drivers today ignore police information, like actions, and still being ignored after patch 1.
patch 2 updates the drivers to use that information instead of ignoring it. so it fixes the drivers that without patch 1 can't be fixed.
Thanks, Roi
| |