Messages in this thread | | | Date | Tue, 15 Feb 2022 15:59:35 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH printk v1 05/13] printk: call boot_delay_msec() in printk_delay() |
| |
On Tue 2022-02-15 14:58:51, Sergey Senozhatsky wrote: > On (22/02/07 20:49), John Ogness wrote: > > boot_delay_msec() is always called immediately before printk_delay() > > so just call it from within printk_delay(). > > > > Signed-off-by: John Ogness <john.ogness@linutronix.de> > > Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> > > > -static inline void printk_delay(void) > > +static inline void printk_delay(int level) > > { > > + boot_delay_msec(level); > > + > > if (unlikely(printk_delay_msec)) { > > int m = printk_delay_msec; > > > > @@ -2224,8 +2226,7 @@ asmlinkage int vprintk_emit(int facility, int level, > > in_sched = true; > > } > > > > - boot_delay_msec(level); > > - printk_delay(); > > + printk_delay(level); > > As a side note, I wonder why do boot_delay_msec() and printk_delay() > touch only NMI watchdog. Shouldn't they also touch softlockup, WQ, > RCU, etc. watchdogs?
It seems that touch_nmi_watchdog() actually calls touch_softlockup_watchdog() that calls wq_watchdog_touch().
Best Regards, Petr
| |