Messages in this thread | | | From | Christophe Leroy <> | Subject | Re: [PATCH v2 12/13] powerpc/ftrace: Prepare ftrace_64_mprofile.S for reuse by PPC32 | Date | Tue, 15 Feb 2022 08:33:07 +0000 |
| |
Le 14/02/2022 à 18:51, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> PPC64 mprofile versions and PPC32 are very similar. >> >> Modify PPC64 version so that if can be reused for PPC32. >> >> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> >> --- >> .../powerpc/kernel/trace/ftrace_64_mprofile.S | 73 +++++++++++++------ >> 1 file changed, 51 insertions(+), 22 deletions(-) > > While I agree that ppc32 and -mprofile-kernel ftrace code are very > similar, I think this patch adds way too many #ifdefs. IMHO, this > makes the resultant code quite difficult to follow.
Ok, I can introduce some GAS macros for a few of them in a followup patch.
Christophe
| |