lkml.org 
[lkml]   [2022]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular
From


On 2022/2/16 5:26 上午, Bart Van Assche wrote:
> On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote:
>> diff --git a/block/Makefile b/block/Makefile
>> index f38eaa612929..f6a3995af285 100644
>> --- a/block/Makefile
>> +++ b/block/Makefile
>> @@ -17,7 +17,8 @@ obj-$(CONFIG_BLK_DEV_BSGLIB)    += bsg-lib.o
>>   obj-$(CONFIG_BLK_CGROUP)    += blk-cgroup.o
>>   obj-$(CONFIG_BLK_CGROUP_RWSTAT)    += blk-cgroup-rwstat.o
>>   obj-$(CONFIG_BLK_DEV_THROTTLING)    += blk-throttle.o
>> -obj-$(CONFIG_BLK_CGROUP_IOPRIO)    += blk-ioprio.o
>> +io-prio-y             := blk-ioprio.o
>> +obj-$(CONFIG_BLK_CGROUP_IOPRIO)    += io-prio.o
>>   obj-$(CONFIG_BLK_CGROUP_IOLATENCY)    += blk-iolatency.o
>>   obj-$(CONFIG_BLK_CGROUP_IOCOST)    += blk-iocost.o
>>   obj-$(CONFIG_MQ_IOSCHED_DEADLINE)    += mq-deadline.o
>
> Is the above change really necessary?

Except for making maintaining easier on a running system, removing a
rqos policy module with cgroup supporting can release a blk-cgroup
policy slots. As BLKCG_MAX_POLS, the max slots number is fixed now.

>
>> +static int blk_ioprio_init(struct request_queue *q);
>>   static struct rq_qos_ops blkcg_ioprio_ops = {
>
> Please insert a blank line between a function declaration and a structure definition.

Yes, I will do it in next version.

Thanks
Jianchao

\
 
 \ /
  Last update: 2022-02-16 03:10    [W:0.119 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site