Messages in this thread | | | Date | Tue, 15 Feb 2022 09:37:45 -0800 | Subject | Re: [PATCH v2] [hpsa] Fix the wrong chars in comment section | From | Bart Van Assche <> |
| |
On 2/14/22 17:52, James Wang wrote: > These '+' should be redundant. > > Signed-off-by: James Wang <jnwang@linux.alibaba.com> > Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Please do NOT add a Reviewed-by tag if a reviewer has not posted that tag himself.
I have the following additional comments on this patch: - I am not convinced that this patch is useful since it does not help users of the hpsa driver. - The comment still does not conform to the Linux kernel coding style. From coding-style.rst:
The preferred style for long (multi-line) comments is:
.. code-block:: c
/* * This is the preferred style for multi-line * comments in the Linux kernel source code. * Please use it consistently. * * Description: A column of asterisks on the left side, * with beginning and ending almost-blank lines. */
Bart.
| |