Messages in this thread | | | Subject | Re: [PATCH v3 15/31] clk: mediatek: Implement mtk_clk_unregister_fixed_clks() API | From | Chun-Jie Chen <> | Date | Tue, 15 Feb 2022 14:35:39 +0800 |
| |
On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > mtk_clk_register_fixed_clks(), as the name suggests, is used to > register > a given list of fixed rate clks. However it is lacking a counterpart > unregister API. > > Implement said unregister API so that the various clock platform > drivers > can utilize it to do proper unregistration, cleanup and removal. > > In the header file, the register function's declaration is also > reformatted to fit code style guidelines. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com>
Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com> > --- > drivers/clk/mediatek/clk-mtk.c | 20 ++++++++++++++++++++ > drivers/clk/mediatek/clk-mtk.h | 6 ++++-- > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mtk.c > b/drivers/clk/mediatek/clk-mtk.c > index 0c5db3c71fdd..7c0d5706eed7 100644 > --- a/drivers/clk/mediatek/clk-mtk.c > +++ b/drivers/clk/mediatek/clk-mtk.c > @@ -80,6 +80,26 @@ void mtk_clk_register_fixed_clks(const struct > mtk_fixed_clk *clks, > } > EXPORT_SYMBOL_GPL(mtk_clk_register_fixed_clks); > > +void mtk_clk_unregister_fixed_clks(const struct mtk_fixed_clk *clks, > int num, > + struct clk_onecell_data *clk_data) > +{ > + int i; > + > + if (!clk_data) > + return; > + > + for (i = num; i > 0; i--) { > + const struct mtk_fixed_clk *rc = &clks[i - 1]; > + > + if (IS_ERR_OR_NULL(clk_data->clks[rc->id])) > + continue; > + > + clk_unregister_fixed_rate(clk_data->clks[rc->id]); > + clk_data->clks[rc->id] = ERR_PTR(-ENOENT); > + } > +} > +EXPORT_SYMBOL_GPL(mtk_clk_unregister_fixed_clks); > + > void mtk_clk_register_factors(const struct mtk_fixed_factor *clks, > int num, struct clk_onecell_data *clk_data) > { > diff --git a/drivers/clk/mediatek/clk-mtk.h > b/drivers/clk/mediatek/clk-mtk.h > index 168220f85489..cc7f920eabb4 100644 > --- a/drivers/clk/mediatek/clk-mtk.h > +++ b/drivers/clk/mediatek/clk-mtk.h > @@ -34,8 +34,10 @@ struct mtk_fixed_clk { > .rate = _rate, \ > } > > -void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, > - int num, struct clk_onecell_data *clk_data); > +void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, > int num, > + struct clk_onecell_data *clk_data); > +void mtk_clk_unregister_fixed_clks(const struct mtk_fixed_clk *clks, > int num, > + struct clk_onecell_data *clk_data); > > struct mtk_fixed_factor { > int id;
| |