lkml.org 
[lkml]   [2022]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 135/172] vt_ioctl: add array_index_nospec to VT_ACTIVATE
    Date
    From: Jakob Koschel <jakobkoschel@gmail.com>

    commit 28cb138f559f8c1a1395f5564f86b8bbee83631b upstream.

    in vt_setactivate an almost identical code path has been patched
    with array_index_nospec. In the VT_ACTIVATE path the user input
    is from a system call argument instead of a usercopy.
    For consistency both code paths should have the same mitigations
    applied.

    Kasper Acknowledgements: Jakob Koschel, Brian Johannesmeyer, Kaveh
    Razavi, Herbert Bos, Cristiano Giuffrida from the VUSec group at VU
    Amsterdam.

    Co-developed-by: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
    Signed-off-by: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
    Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
    Link: https://lore.kernel.org/r/20220127144406.3589293-2-jakobkoschel@gmail.com
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/tty/vt/vt_ioctl.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/tty/vt/vt_ioctl.c
    +++ b/drivers/tty/vt/vt_ioctl.c
    @@ -845,6 +845,7 @@ int vt_ioctl(struct tty_struct *tty,
    return -ENXIO;

    arg--;
    + arg = array_index_nospec(arg, MAX_NR_CONSOLES);
    console_lock();
    ret = vc_allocate(arg);
    console_unlock();

    \
     
     \ /
      Last update: 2022-02-14 11:40    [W:4.058 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site