lkml.org 
[lkml]   [2022]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] firmware_loader: EXTRA_FIRMWARE does not support compressed files
From


On 2/14/22 17:53, Luis Chamberlain wrote:
> On Mon, Feb 14, 2022 at 02:23:11PM -0800, Randy Dunlap wrote:
>> Document in the firmware loader Kconfig help text that firmware image
>> file compression is not supported for builtin EXTRA_FIRMWARE files so
>> that someone does not waste time trying that.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>> ---
>> Yeah, I wasted some time trying to use an xz compressed file
>> as builtin EXTRA_FIRMWARE,
>
> Curious *why* you are using EXTRA_FIRMWARE BTW.

Hi Luis,

I need to load i915 firmware very early
and I am not using an initramfs.

>> so try to prevent someone else from
>> doing that.
>
> Acked-by: Luis Chamberlain <mcgrof@kernel.org>

Thanks.

> Luis
>>
>> drivers/base/firmware_loader/Kconfig | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> --- linux-next-20220214.orig/drivers/base/firmware_loader/Kconfig
>> +++ linux-next-20220214/drivers/base/firmware_loader/Kconfig
>> @@ -60,6 +60,8 @@ config EXTRA_FIRMWARE
>> image since it combines both GPL and non-GPL work. You should
>> consult a lawyer of your own before distributing such an image.
>>
>> + NOTE: Compressed files are not supported in EXTRA_FIRMWARE.
>> +
>> config EXTRA_FIRMWARE_DIR
>> string "Firmware blobs root directory"
>> depends on EXTRA_FIRMWARE != ""
>> @@ -169,6 +171,9 @@ config FW_LOADER_COMPRESS
>> be compressed with either none or crc32 integrity check type (pass
>> "-C crc32" option to xz command).
>>
>> + Compressed firmware support does not apply to firmware images
>> + that are built into the kernel image (CONFIG_EXTRA_FIRMWARE).
>> +
>> config FW_CACHE
>> bool "Enable firmware caching during suspend"
>> depends on PM_SLEEP

--
~Randy

\
 
 \ /
  Last update: 2022-02-15 04:31    [W:0.066 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site