Messages in this thread | | | Date | Mon, 14 Feb 2022 09:07:39 +0100 | Subject | Re: [PATCH 1/2] ahci: Add Green Sardine vendor ID as board_ahci_mobile | From | Paul Menzel <> |
| |
Dear Mario,
(For the records, is part of Linux since 5.16-rc2 (commit 1527f69204fe).)
Am 12.11.21 um 21:15 schrieb Mario Limonciello: > AMD requires that the SATA controller be configured for devsleep in order > for S0i3 entry to work properly. > > commit b1a9585cc396 ("ata: ahci: Enable DEVSLP by default on x86 with > SLP_S0") sets up a kernel policy to enable devsleep on Intel mobile > platforms that are using s0ix. Add the PCI ID for the SATA controller in > Green Sardine platforms to extend this policy by default for AMD based > systems using s0i3 as well. > > Cc: Nehal-bakulchandra Shah <Nehal-bakulchandra.Shah@amd.com> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214091 > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/ata/ahci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index d60f34718b5d..1e1167e725a4 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -438,6 +438,7 @@ static const struct pci_device_id ahci_pci_tbl[] = { > /* AMD */ > { PCI_VDEVICE(AMD, 0x7800), board_ahci }, /* AMD Hudson-2 */ > { PCI_VDEVICE(AMD, 0x7900), board_ahci }, /* AMD CZ */ > + { PCI_VDEVICE(AMD, 0x7901), board_ahci_mobile }, /* AMD Green Sardine */
Aren’t 0x7900 and 0x7901 the same device only in different modes? I wonder, why different boards and different comments are used.
Additionally, the device 0x7901 is also present in desktop systems like Dell OptiPlex 5055 and MSI B350 MORTAR. Is `board_ahci_mobile` the right board then? Or should the flag `AHCI_HFLAG_IS_MOBILE` be renamed to avoid confusion?
> /* AMD is using RAID class only for ahci controllers */ > { PCI_VENDOR_ID_AMD, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, > PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
Kind regards,
Paul
| |