lkml.org 
[lkml]   [2022]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] iommu/ipmmu-vmsa: Check for error num after setting mask
From
> Adding more potential reviewers.
>
> On Thu, Jan 06, 2022 at 10:43:02AM +0800, Jiasheng Jiang wrote:
>> Because of the possible failure of the dma_supported(), the
>> dma_set_mask_and_coherent() may return error num.
>> Therefore, it should be better to check it and return the error if
>> fails.

Indeed, most uses of dma_set_mask_and_coherent() in the kernel do check return value.

Reviewed-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>

\
 
 \ /
  Last update: 2022-02-14 13:01    [W:0.047 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site