Messages in this thread | | | Date | Sun, 13 Feb 2022 20:42:00 +0100 | From | Dominik Brodowski <> | Subject | Re: [PATCH] random: pull add_hwgenerator_randomness() declaration into random.h |
| |
Am Sun, Feb 13, 2022 at 04:25:22PM +0100 schrieb Jason A. Donenfeld: > add_hwgenerator_randomness() is a function implemented and documented > inside of random.c. It is the way that hardware RNGs push data into it. > Therefore, it should be declared in random.h. Otherwise sparse complains > with: > > random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static? > > The alternative would be to include hw_random.h into random.c, but that > wouldn't really be good for anything except slowing down compile time.
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
| |