Messages in this thread | | | Date | Sun, 13 Feb 2022 11:13:27 -0800 | Subject | Re: [PATCH] bcma: cleanup comments | From | Randy Dunlap <> |
| |
Hi--
On 2/13/22 09:20, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Remove the second 'info'. ack
> Replacements > 'adventages' with 'advantages' ack
> 'strenth' with 'strength' ack
> 'atleast' with 'at least' ack
> 'thr'u'' with 'through' ack, or even "thru" is acceptable.
> 'capabilty' with 'capability' ack
> 'controll' with 'control' ack
> 'ourself' with 'our self' I don't think so.
> 'noone' with 'no one' ack
More below:
> > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/bcma/driver_chipcommon.c | 2 +- > drivers/bcma/driver_chipcommon_pmu.c | 6 +++--- > drivers/bcma/driver_pci_host.c | 6 +++--- > drivers/bcma/main.c | 4 ++-- > drivers/bcma/sprom.c | 4 ++-- > 5 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/bcma/driver_chipcommon.c b/drivers/bcma/driver_chipcommon.c > index 62f5bfa5065d..fd91a39f02c7 100644 > --- a/drivers/bcma/driver_chipcommon.c > +++ b/drivers/bcma/driver_chipcommon.c
> diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c > index 8e7ca3e4c8c4..bf6efe3caf68 100644 > --- a/drivers/bcma/main.c > +++ b/drivers/bcma/main.c > @@ -293,7 +293,7 @@ static int bcma_register_devices(struct bcma_bus *bus) > int err; > > list_for_each_entry(core, &bus->cores, list) { > - /* We support that cores ourself */ > + /* We support that cores our self */
I would s/cores/core/.
From my $search_engine doodling, it looks like "ourself" or "ourselves" would be OK.
> switch (core->id.id) { > case BCMA_CORE_4706_CHIPCOMMON: > case BCMA_CORE_CHIPCOMMON:
> diff --git a/drivers/bcma/sprom.c b/drivers/bcma/sprom.c > index bd2c923a6586..fb2789827e83 100644 > --- a/drivers/bcma/sprom.c > +++ b/drivers/bcma/sprom.c
> @@ -281,7 +281,7 @@ static void bcma_sprom_extract_r8(struct bcma_bus *bus, const u16 *sprom) > SPEX(alpha2[0], SSB_SPROM8_CCODE, 0xff00, 8); > SPEX(alpha2[1], SSB_SPROM8_CCODE, 0x00ff, 0); > > - /* Extract cores power info info */ > + /* Extract cores power info */
or each core's power info */
> for (i = 0; i < ARRAY_SIZE(pwr_info_offset); i++) { > o = pwr_info_offset[i]; > SPEX(core_pwr_info[i].itssi_2g, o + SSB_SROM8_2G_MAXP_ITSSI,
-- ~Randy
| |