Messages in this thread | | | Date | Sun, 13 Feb 2022 16:21:50 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix validation of built-in PHYs on 6095/6097 |
| |
On Sun, Feb 13, 2022 at 04:32:51PM +0100, Tobias Waldekranz wrote: > On Sun, Feb 13, 2022 at 12:58, "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > > I'm wondering what the point of checking the cmode here is - if the port > > is internal, won't this switch always have cmode == PHY? > > For all intents and purposes: I think so. It is just that the functional > spec. also lists cmode == 4 == disabled (PHYDetect == 0) for the > internal ports. So I figured that there might be some way of strapping > ports as disabled that I had never come across.
I don't think there is a way to pinstrap the internal ports. As far as I can see, the only way would be for software to program PHY Detect to zero.
If we wanted a port to be disabled, then describing it in firmware as being enabled would be a bug. If it isn't described in firmware, the DSA code won't even consider looking at the port.
> Do you think we should drop it?
I think so.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |