Messages in this thread | | | Date | Fri, 11 Feb 2022 06:57:03 +0100 | From | Dominik Brodowski <> | Subject | Re: [PATCH v2] random: deobfuscate irq u32/u64 contributions |
| |
Am Thu, Feb 10, 2022 at 06:13:22PM +0100 schrieb Jason A. Donenfeld: > In the irq handler, we fill out 16 bytes differently on 32-bit and > 64-bit platforms. Whether or not you like that, it is a matter of fact. > But it might not be a fact you well realized until now, because the code > that loaded the irq info into 4 32-bit words was quite confusing. > Instead, this commit makes everything explicit by having separate > (compile-time) branches for 32-bit and 64-bit machines. In the process, > we now easily see that we were truncating the contribution of > random_get_entropy() in mix_interrupt_randomness() which we rectify by > using the correct integer type. > > Cc: Theodore Ts'o <tytso@mit.edu> > Cc: Dominik Brodowski <linux@dominikbrodowski.net> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks, Dominik
| |