Messages in this thread | | | From | Menglong Dong <> | Date | Fri, 11 Feb 2022 16:49:50 +0800 | Subject | Re: [PATCH v3 net-next 1/7] net: skb_drop_reason: add document for drop reasons |
| |
On Fri, Feb 11, 2022 at 12:13 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Thu, 10 Feb 2022 21:42:14 +0800 Menglong Dong wrote: > > How about introducing a field to 'struct sock' for drop reasons? As sk is > > locked during the packet process in tcp_v4_do_rcv(), this seems to work. > > I find adding temporary storage to persistent data structures awkward. > You can put a structure on the stack and pass it thru the call chain, > that's just my subjective preference, tho, others may have better ideas.
Yes, I also feel it is awkward. I'll try to do this job by passing drop reasons through the call chain. Thanks for your help :)
| |