Messages in this thread | | | Date | Thu, 10 Feb 2022 17:42:21 +0100 | Subject | Re: [PATCH MANUALSEL 5.16 3/8] KVM: nVMX: Also filter MSR_IA32_VMX_TRUE_PINBASED_CTLS when eVMCS | From | Paolo Bonzini <> |
| |
On 2/9/22 19:56, Sasha Levin wrote: > From: Vitaly Kuznetsov <vkuznets@redhat.com> > > [ Upstream commit f80ae0ef089a09e8c18da43a382c3caac9a424a7 ] > > Similar to MSR_IA32_VMX_EXIT_CTLS/MSR_IA32_VMX_TRUE_EXIT_CTLS, > MSR_IA32_VMX_ENTRY_CTLS/MSR_IA32_VMX_TRUE_ENTRY_CTLS pair, > MSR_IA32_VMX_TRUE_PINBASED_CTLS needs to be filtered the same way > MSR_IA32_VMX_PINBASED_CTLS is currently filtered as guests may solely rely > on 'true' MSR data. > > Note, none of the currently existing Windows/Hyper-V versions are known > to stumble upon the unfiltered MSR_IA32_VMX_TRUE_PINBASED_CTLS, the change > is aimed at making the filtering future proof.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > Message-Id: <20220112170134.1904308-2-vkuznets@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > arch/x86/kvm/vmx/evmcs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kvm/vmx/evmcs.c b/arch/x86/kvm/vmx/evmcs.c > index 09fac0ddac8bd..87e3dc10edf40 100644 > --- a/arch/x86/kvm/vmx/evmcs.c > +++ b/arch/x86/kvm/vmx/evmcs.c > @@ -361,6 +361,7 @@ void nested_evmcs_filter_control_msr(u32 msr_index, u64 *pdata) > case MSR_IA32_VMX_PROCBASED_CTLS2: > ctl_high &= ~EVMCS1_UNSUPPORTED_2NDEXEC; > break; > + case MSR_IA32_VMX_TRUE_PINBASED_CTLS: > case MSR_IA32_VMX_PINBASED_CTLS: > ctl_high &= ~EVMCS1_UNSUPPORTED_PINCTRL; > break;
| |