Messages in this thread | | | From | Shakeel Butt <> | Date | Thu, 10 Feb 2022 14:23:37 -0800 | Subject | Re: [PATCH 1/4] memcg: refactor mem_cgroup_oom |
| |
On Thu, Feb 10, 2022 at 11:53 AM Roman Gushchin <guro@fb.com> wrote: > > On Thu, Feb 10, 2022 at 12:14:34AM -0800, Shakeel Butt wrote: > > The function mem_cgroup_oom returns enum which has four possible values > > but the caller does not care about such values and only care if the > > return value is OOM_SUCCESS or not. So, remove the enum altogether and > > make mem_cgroup_oom returns a simple bool. > > > > Signed-off-by: Shakeel Butt <shakeelb@google.com> > > Nice! > > Reviewed-by: Roman Gushchin <guro@fb.com>
Thanks. > [...] > > The only thing, I'd add a small comment on the return value here. E.g. > "returns true if one or more tasks have been successfully killed" or something > like this. >
Will do in the next version.
| |