lkml.org 
[lkml]   [2022]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 026/239] f2fs: fix to do sanity check in is_alive()
Hi!

> Oops, you're right, my bad.
>
> >
> > > +++ b/fs/f2fs/gc.c
> > > @@ -589,6 +589,9 @@ static bool is_alive(struct f2fs_sb_info
> > > set_sbi_flag(sbi, SBI_NEED_FSCK);
> > > }
> > > + if (f2fs_check_nid_range(sbi, dni->ino))
> > > + return false;
> > > +
> > > *nofs = ofs_of_node(node_page);
> > > source_blkaddr = datablock_addr(NULL, node_page, ofs_in_node);
> > > f2fs_put_page(node_page, 1);
> >
> > AFAICT f2fs_put_page() needs to be done in the error path, too.
> >
> > (Problem seems to exist in mainline, too).
> >
> > Something like this?
>
> Could you please send a formal patch to f2fs mailing list for better review?
>
> Anyway, thanks a lot for the report and the patch!

I'm quite busy with other reviews at the moment. If you could submit a
patch, it would be great, otherwise I'll get to it .. sometime.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-02-01 20:18    [W:0.143 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site