lkml.org 
[lkml]   [2022]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/memory_hotplug: build zonelist for managed_zone
On Mon, Jan 31, 2022 at 11:24:48AM +0100, Michal Hocko wrote:
>> >> This patch restore the original behavior by using the same criteria to
>> >> add a zone in zonelist during memory hotplug.
>> >
>> >Why?
>> >
>>
>> In case we online a populated zone, but not managed. Then this zone will not
>> be in zonelist. Right?
>
>yeah. We can theoretically end up with a zone without any managed menory
>on the zonelists. But my primary question is why do we need this change?

Currently I don't see a real case for this.

>Does it fix any existing problem? Does it make the code easier to
>read/understand? Does it improve performance? Every patch should have a
>justification. Your changelog merely lists the history and then states
>the new behavior without any explanation of why that is needed or
>desired. See?

I don't have such reason now.

>--
>Michal Hocko
>SUSE Labs

--
Wei Yang
Help you, Help me

\
 
 \ /
  Last update: 2022-02-01 07:34    [W:0.061 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site