Messages in this thread | | | From | Alistair Francis <> | Date | Tue, 1 Feb 2022 15:37:23 +1000 | Subject | Re: [PATCH v5 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t |
| |
On Fri, Dec 10, 2021 at 11:36 PM Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote: > > Em Fri, Dec 10, 2021 at 09:58:52AM +1000, Alistair Francis escreveu: > > From: Alistair Francis <alistair.francis@wdc.com> > > > > Some 32-bit architectures (such are 32-bit RISC-V) only have a 64-bit > > time_t and as such don't have the SYS_futex syscall. This patch will > > allow us to use the SYS_futex_time64 syscall on those platforms. > > > > This also converts the futex calls to be y2038 safe (when built for a > > 5.1+ kernel). > > > > This is a revert of commit ba4026b09d83acf56c040b6933eac7916c27e728 > > "Revert "perf bench futex: Add support for 32-bit systems with 64-bit time_t"". > > > > The original commit was reverted as including linux/time_types.h would > > fail to compile on older kernels. This commit doesn't include > > linux/time_types.h to avoid this issue. > > 10 9.99 alpine:3.12 : FAIL gcc version 9.3.0 (Alpine 9.3.0) > In file included from bench/futex-hash.c:29: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > 37 | __kernel_old_time_t tv_sec; /* seconds */ > | ^~~~~~~~~~~~~~~~~~~ > In file included from bench/futex-wake.c:25: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > 37 | __kernel_old_time_t tv_sec; /* seconds */ > | ^~~~~~~~~~~~~~~~~~~ > make[3]: *** [/git/perf-5.16.0-rc4/tools/build/Makefile.build:139: bench] Error 2 > 11 114.27 alpine:3.13 : Ok gcc (Alpine 10.2.1_pre1) 10.2.1 20201203 , Alpine clang version 10.0.1 > 12 100.12 alpine:3.14 : Ok gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424 , Alpine clang version 11.1.0 > 13 101.06 alpine:3.15 : Ok gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027 , Alpine clang version 12.0.1 > 14 101.96 alpine:edge : Ok gcc (Alpine 11.2.1_git20211128) 11.2.1 20211128 , Alpine clang version 12.0.1 > 15 6.98 alt:p8 : FAIL gcc version 5.3.1 20151207 (ALT p8 5.3.1-alt3.M80P.1) (GCC) > In file included from bench/futex-hash.c:29:0: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > __kernel_old_time_t tv_sec; /* seconds */ > ^ > In file included from bench/futex-wake.c:25:0: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > __kernel_old_time_t tv_sec; /* seconds */ > ^ > In file included from bench/futex-wake-parallel.c:31:0: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > __kernel_old_time_t tv_sec; /* seconds */ > ^ > make[3]: *** [bench] Error 2 > 16 73.65 alt:p9 : Ok x86_64-alt-linux-gcc (GCC) 8.4.1 20200305 (ALT p9 8.4.1-alt0.p9.1) , clang version 10.0.0 > 17 72.34 alt:sisyphus : Ok x86_64-alt-linux-gcc (GCC) 11.2.1 20210911 (ALT Sisyphus 11.2.1-alt1) , ALT Linux Team clang version 12.0.1 > 18 7.58 amazonlinux:1 : FAIL gcc version 7.2.1 20170915 (Red Hat 7.2.1-2) (GCC) > In file included from bench/futex-hash.c:29:0: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > __kernel_old_time_t tv_sec; /* seconds */ > ^~~~~~~~~~~~~~~~~~~ > In file included from bench/futex-wake.c:25:0: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > __kernel_old_time_t tv_sec; /* seconds */ > ^~~~~~~~~~~~~~~~~~~ > make[3]: *** [bench] Error 2 > 19 8.28 amazonlinux:2 : FAIL gcc version 7.3.1 20180712 (Red Hat 7.3.1-13) (GCC) > In file included from bench/futex-hash.c:29:0: > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t' > __kernel_old_time_t tv_sec; /* seconds */ > ^~~~~~~~~~~~~~~~~~~ > make[3]: *** [bench] Error 2 > 20 79.16 centos:8 : Ok gcc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1) , clang version 11.0.1 (Red Hat 11.0.1-1.module_el8.4.0+966+2995ef20)
Is there a way I can reproduce this failure?
Alistair
> > > Still building on the other containers. > > - Arnaldo
| |