Messages in this thread | | | Date | Tue, 1 Feb 2022 11:37:53 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 5.10 089/100] net: cpsw: Properly initialise struct page_pool_params |
| |
On Mon, Jan 31, 2022 at 12:19:09PM -0800, Colin Foster wrote: > On Mon, Jan 31, 2022 at 11:56:50AM +0100, Greg Kroah-Hartman wrote: > > From: Toke Høiland-Jørgensen <toke@redhat.com> > > > > [ Upstream commit c63003e3d99761afb280add3b30de1cf30fa522b ] > > > > The cpsw driver didn't properly initialise the struct page_pool_params > > before calling page_pool_create(), which leads to crashes after the struct > > has been expanded with new parameters. > > > > The second Fixes tag below is where the buggy code was introduced, but > > because the code was moved around this patch will only apply on top of the > > commit in the first Fixes tag. > > > > Fixes: c5013ac1dd0e ("net: ethernet: ti: cpsw: move set of common functions in cpsw_priv") > > Fixes: 9ed4050c0d75 ("net: ethernet: ti: cpsw: add XDP support") > > In 5.4 every parameter is individually initialized, so there really > isn't a "bug" necessarily. Only at commit e68bc75691cc does it actually > start not initializing every parameter. > > https://elixir.bootlin.com/linux/v5.4.175/source/drivers/net/ethernet/ti/cpsw.c#L558 > > I'm not familiar with the process of backporting fixes to stable yet. Is > there any benefit in this cleanup for 5.4 or is it fine to leave it?
Let's be safe and leave it.
thanks,
greg k-h
| |