Messages in this thread | | | Date | Tue, 1 Feb 2022 11:20:29 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v5 08/13] ACPI: add perf low power callback |
| |
On Mon, Jan 31, 2022 at 11:33:10PM -0800, Stephane Eranian wrote: > On Thu, Jan 27, 2022 at 5:06 AM Peter Zijlstra <peterz@infradead.org> wrote: > > > > On Wed, Jan 26, 2022 at 03:34:49PM -0800, Stephane Eranian wrote: > > > This patch add an optional callback needed by some PMU features, e.g., AMD > > > > "This patch" is a documented fail. > > > I understand this is not ideal.
git grep -i "this patch" Documentation/process/submitting-patches.rst
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."
IOW, don't use "This patch" to start a Changelog (lot's of your patches here do so).
| |