Messages in this thread | | | From | Nick Desaulniers <> | Date | Fri, 9 Dec 2022 10:17:08 -0800 | Subject | Re: [PATCH v2 0/4] objtool build improvements |
| |
On Mon, Nov 21, 2022 at 4:11 PM Ian Rogers <irogers@google.com> wrote: > > Install libsubcmd and then get headers from there, this avoids > inadvertent dependencies on things in tools/lib. Fix V=1 > support. Clean up how HOSTCC is used to override CC to avoid CFLAGS > being set for say gcc, and then CC being overridden to clang. Support > HOSTCFLAGS as a make option.
Ian, I'm terribly sorry about the delay in reviewing this; usually my turnaround time is much lower on code review...
Anyways, the patchset LGTM; thanks for the work that went into this.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> > v2. Include required "tools lib subcmd: Add install target" that is > already in Arnaldo's tree: > https://lore.kernel.org/lkml/20221109184914.1357295-3-irogers@google.com/ > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=630ae80ea1dd253609cb50cff87f3248f901aca3 > When building libsubcmd.a from objtool's Makefile, clear the > subdir to avoid it being appended onto OUTPUT and breaking the > build. > > Ian Rogers (4): > tools lib subcmd: Add install target > objtool: Install libsubcmd in build > objtool: Properly support make V=1 > objtool: Alter how HOSTCC is forced > > tools/lib/subcmd/Makefile | 49 ++++++++++++++++++++++++++++ > tools/objtool/Build | 2 -- > tools/objtool/Makefile | 68 +++++++++++++++++++++++++++------------ > 3 files changed, 97 insertions(+), 22 deletions(-) > > -- > 2.38.1.584.g0f3c55d4c2-goog >
-- Thanks, ~Nick Desaulniers
| |